Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(actions-dialog): add action parameter selection dialog #1110

Merged
merged 4 commits into from
Dec 15, 2021
Merged

add(actions-dialog): add action parameter selection dialog #1110

merged 4 commits into from
Dec 15, 2021

Conversation

vincent10400094
Copy link
Contributor

@vincent10400094 vincent10400094 commented Dec 14, 2021 •
edited by sync-by-unito bot
Loading

#1049

  • Use mat-dialog instead of ionic alert to support multiple types of input
    • text input
    • number input
    • dropdown (select)
  • Display more information about each input
  • Checking the input when submitting the form

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

shc261392
shc261392 approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@shc261392 shc261392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

@vincent10400094 vincent10400094 merged commit 8ba0a56 into develop Dec 15, 2021
@vincent10400094 vincent10400094 deleted the feature-update-network-application-ui branch December 15, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shc261392 shc261392 shc261392 approved these changes

Assignees

@vincent10400094 vincent10400094

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent10400094 @shc261392