Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding sphinx_rtd_theme to RTD build to fix build #998

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

esc
Copy link
Member

@esc esc commented Oct 10, 2023

As of recently, docs started failing:

https://readthedocs.org/projects/llvmlite/builds/22167903/

The error was:

Configuration error:
There is a programmable error in your configuration file:

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/llvmlite/envs/latest/lib/python3.11/site-packages/sphinx/config.py", line 358, in eval_config_file
    exec(code, namespace)  # NoQA: S102
    ^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/llvmlite/checkouts/latest/docs/source/conf.py", line 20, in <module>
    import sphinx_rtd_theme
ModuleNotFoundError: No module named 'sphinx_rtd_theme'

This fixes that.

@esc esc added this to the 0.41.1 milestone Oct 10, 2023
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. RTD builds ok

@esc esc changed the title adding sphinx_rtd_theme adding sphinx_rtd_theme to RTD build to fix build Oct 10, 2023
@esc
Copy link
Member Author

esc commented Oct 11, 2023

@sklam thank you for the review!

@esc esc merged commit cbdc770 into numba:main Oct 11, 2023
@esc esc deleted the fix_rtd_missing_sphinx_rtd_theme branch October 11, 2023 09:27
esc added a commit to esc/llvmlite that referenced this pull request Oct 12, 2023
adding sphinx_rtd_theme to RTD build to fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants