Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency pymodbus to <3.5.0 #56

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 20, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
pymodbus >=3.0.2,<3.4.0 -> <3.5.0 age adoption passing confidence

Release Notes

pymodbus-dev/pymodbus (pymodbus)

v3.4.0

Compare Source

Thanks to:
Alex
Fredo70
Hangyu Fan
James Braza
jan iversen


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot changed the title Update dependency pymodbus to v3.4.0 Update dependency pymodbus to >=3.4.0,<3.5.0 Jul 20, 2023
@renovate renovate bot force-pushed the renovate/pymodbus-3.x branch 2 times, most recently from 5749d9c to 3bb2f1c Compare July 20, 2023 14:38
@alexrudd2 alexrudd2 marked this pull request as draft July 20, 2023 15:19
@alexrudd2 alexrudd2 force-pushed the renovate/pymodbus-3.x branch from 3bb2f1c to 8db5ac0 Compare July 20, 2023 19:54
@renovate
Copy link
Contributor Author

renovate bot commented Jul 20, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@alexrudd2 alexrudd2 changed the title Update dependency pymodbus to >=3.4.0,<3.5.0 Update dependency pymodbus to <3.5.0 Jul 20, 2023
@alexrudd2
Copy link
Member

Traceback (most recent call last):
  File "/src/controllers/controllers/lab_ovens/controller.py", line 237, in get_vac_oven
    temperature = await self.vac_oven_gateway.get(i + 1)
  File "/usr/local/lib/python3.10/site-packages/watlow/driver.py", line 207, in get
    result = await self.read_registers(address, 2)
  File "/usr/local/lib/python3.10/site-packages/watlow/util.py", line 76, in read_registers
    r = await self._request('read_holding_registers', address, count)
  File "/usr/local/lib/python3.10/site-packages/watlow/util.py", line 130, in _request
    raise TimeoutError("Not connected to Watlow gateway")
TimeoutError: Not connected to Watlow gateway
03:21:23 PM CDT, 20 Jul 2023
ERROR get_vac_oven:241
Reading vacuum oven 1 failed
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/watlow/util.py", line 128, in _request
    return await future(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/pymodbus/client/mixin.py", line 102, in read_holding_registers
    return self.execute(
  File "/usr/local/lib/python3.10/site-packages/pymodbus/client/base.py", line 182, in execute
    raise ConnectionException(f"Not connected[{str(self)}]")
pymodbus.exceptions.ConnectionException: Modbus Error: [Connection] Not connected[AsyncModbusTcpClient 192.168.10.242:502]

@alexrudd2
Copy link
Member

I bisected the problem and upstream fixed it, so it'll be released in 3.4.1:
pymodbus-dev/pymodbus#1683

@alexrudd2 alexrudd2 force-pushed the renovate/pymodbus-3.x branch from 8db5ac0 to 500a77c Compare July 27, 2023 18:13
@alexrudd2
Copy link
Member

3.4.1 has been released and fixes the problem.

@alexrudd2 alexrudd2 marked this pull request as ready for review July 27, 2023 18:13
@alexrudd2 alexrudd2 merged commit 9491735 into master Jul 27, 2023
@alexrudd2 alexrudd2 deleted the renovate/pymodbus-3.x branch July 27, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant