feat: Add test for ISBServiceRollout #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 7, 2024 09:48
Signed-off-by: Ali Ibrahim <[email protected]>
Signed-off-by: Ali Ibrahim <[email protected]>
afugazzotto
reviewed
Jun 7, 2024
| }, | ||
| Spec: apiv1.ISBServiceRolloutSpec{ | ||
| InterStepBufferService: runtime.RawExtension{ | ||
| Raw: []byte(`{ |
There was a problem hiding this comment.
It would be better to use a more realistic example like https://github.com/numaproj/numaplane/blob/main/config/samples/numaplane.numaproj.io_v1alpha1_isbservicerollout.yaml
Also, I'd recommend not using string but an actual Numaflow InterStepBufferService object so you can reuse it for updates and comparisons (similar to the tests in the PipelineRollout Controller).
afugazzotto
reviewed
Jun 7, 2024
afugazzotto
reviewed
Jun 7, 2024
|
|
||
| // Update the spec here | ||
| currentISBServiceRollout.Spec.InterStepBufferService = runtime.RawExtension{ | ||
| Raw: []byte(`{ |
There was a problem hiding this comment.
See above comment related to this.
Signed-off-by: Ali Ibrahim <[email protected]>
Signed-off-by: Ali Ibrahim <[email protected]>
can you fill in the |
xdevxy
previously approved these changes
Jun 10, 2024
xdevxy
reviewed
Jun 10, 2024
added 2 commits
June 11, 2024 18:37
Signed-off-by: Ali Ibrahim <[email protected]>
Signed-off-by: Ali Ibrahim <[email protected]>
|
The failure is actually related to the latest change and should be fixed with #56 |
xdevxy
approved these changes
Jun 13, 2024
darshansimha
referenced
this pull request
in darshansimha/numaplane
Jun 25, 2024
Signed-off-by: Ali Ibrahim <[email protected]> Co-authored-by: xdevxy <[email protected]> Signed-off-by: dsimha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
Modifications
added test cases to isbservicerollout_controller_test.go file to test create, update, and delete of a isbservicerollout resource.
Verification
ran make test command and verify all tests passed.