feat: add a label to identify the promoted/deployed pipeline for a pipelineRollout #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliev0
reviewed
Sep 17, 2024
juliev0
reviewed
Sep 17, 2024
…pelineRollout Signed-off-by: Hao Hao <[email protected]>
Signed-off-by: Hao Hao <[email protected]>
juliev0
approved these changes
Sep 17, 2024
chandankumar4
pushed a commit
that referenced
this pull request
Sep 19, 2024
…pelineRollout (#273) Signed-off-by: Hao Hao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272
Modifications
Added the label
numaplane.numaproj.io/upgrade-state: promotedto uniquely identify the deployed/promoted pipeline associate with a PipelineRollout, together with labelnumaplane.numaproj.io/pipeline-rollout-name: pipeline-rollout-name, instead of using the PipelineRollout name. And theupgrade-statelabel can only be inpromotedorin-progress, the later should only be used for no down time upgrade feature.Verification
make test