Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add namespace field for pipeline, isb, monovertex and numaflow controller metrics #250

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

chandankumar4
Copy link
Contributor

@chandankumar4 chandankumar4 commented Sep 12, 2024

Fixes #226

Modifications

  • Added metrics with namespace
# HELP numaflow_pipelines_running Number of Numaflow pipelines running
# TYPE numaflow_pipelines_running gauge
numaflow_pipelines_running{intuit_alert="true",namespace="example-namespace"} 1
# HELP numaflow_isb_services_running Number of Numaflow ISB Service running
# TYPE numaflow_isb_services_running gauge
numaflow_isb_services_running{intuit_alert="true",namespace="example-namespace"} 1
# HELP numaflow_monovertices_running Number of Numaflow monovertices running
# TYPE numaflow_monovertices_running gauge
numaflow_monovertices_running{intuit_alert="true",namespace="example-namespace"} 1
# HELP numaflow_controller_running Number of Numaflow controller running
# TYPE numaflow_controller_running gauge
numaflow_controller_running{intuit_alert="true",name="numaflow-controller",namespace="example-namespace",version="1.3.0"} 1

Verification

@chandankumar4 chandankumar4 changed the title feat: Add namespace field for pipeline, isb, monovertex and numaflow … feat: Add namespace field for pipeline, isb, monovertex and numaflow controller metrics Sep 12, 2024
@juliev0
Copy link
Collaborator

juliev0 commented Sep 16, 2024

Just looking at your PR description screen capture, why is the label for numaflow_controller_running called name_namespace instead of namespace like the others?

@chandankumar4
Copy link
Contributor Author

Just looking at your PR description screen capture, why is the label for numaflow_controller_running called name_namespace instead of namespace like the others?

Oh, I have updated the code but forgot to update description. Let me do it..

@xdevxy xdevxy merged commit d4a1cc3 into numaproj:main Sep 16, 2024
8 checks passed
chandankumar4 added a commit that referenced this pull request Sep 19, 2024
@chandankumar4 chandankumar4 deleted the add-namespace-in-metrics branch November 8, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add namespace field in running pipeline/isb/numaflow controller metrics data
3 participants