Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all make targets and add lint, unit tests in github action #25

Merged
merged 1 commit into from
May 31, 2024
Merged

Fix all make targets and add lint, unit tests in github action #25

merged 1 commit into from
May 31, 2024

Conversation

chandankumar4
Copy link
Contributor

@chandankumar4 chandankumar4 commented May 30, 2024 •
edited
Loading

  • Verified all make taregts
  • Added the Lint and unit test in github action

@chandankumar4 chandankumar4 force-pushed the make-targets branch 10 times, most recently from 8366eed to 5dd023b Compare May 31, 2024 08:58
@chandankumar4 chandankumar4 marked this pull request as ready for review May 31, 2024 09:06
@juliev0 juliev0 merged commit 7509dab into numaproj:main May 31, 2024
4 checks passed
@chandankumar4 chandankumar4 deleted the make-targets branch June 3, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliev0 juliev0 juliev0 approved these changes

@xdevxy xdevxy Awaiting requested review from xdevxy

@afugazzotto afugazzotto Awaiting requested review from afugazzotto afugazzotto is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chandankumar4 @juliev0