feat: add pause metrics for ISBService/NumaflowController rollouts #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lowcontroller rollouts Signed-off-by: Dillen Padhiar <[email protected]>
Signed-off-by: Dillen Padhiar <[email protected]>
Signed-off-by: Dillen Padhiar <[email protected]>
xdevxy
approved these changes
Sep 6, 2024
|
I like your very complete github PR descriptions :) |
juliev0
reviewed
Sep 6, 2024
| @@ -36,7 +36,8 @@ type InterStepBufferService struct { | |||
|
|
|||
| // ISBServiceRolloutStatus defines the observed state of ISBServiceRollout | |||
| type ISBServiceRolloutStatus struct { | |||
| Status `json:",inline"` | |||
| Status `json:",inline"` | |||
| PauseStatus `json:"pauseRequestStatus,omitempty"` | |||
There was a problem hiding this comment.
it appears that PauseStatus is inline? I think I'd prefer that it not be. Can you change it to
PauseRequestStatus PauseStatus `json:"pauseRequestStatus,omitempty"?
There was a problem hiding this comment.
I didn't catch that the PipelineRolloutStatus.PauseStatus is the same - can that be changed as well?
Signed-off-by: Dillen Padhiar <[email protected]>
Signed-off-by: Dillen Padhiar <[email protected]>
juliev0
reviewed
Sep 6, 2024
| controllerRollout := rollout.(*apiv1.NumaflowControllerRollout) | ||
|
|
||
| if paused { | ||
| if controllerRollout.Status.PauseRequestStatus.LastPauseBeginTime == metav1.NewTime(initTime) || !controllerRollout.Status.PauseRequestStatus.LastPauseBeginTime.After(controllerRollout.Status.PauseRequestStatus.LastPauseEndTime.Time) { |
There was a problem hiding this comment.
Used same comments as PipelineRollout since they're the same logic.
Signed-off-by: Dillen Padhiar <[email protected]>
juliev0
approved these changes
Sep 6, 2024
chandankumar4
pushed a commit
that referenced
this pull request
Sep 19, 2024
) Signed-off-by: Dillen Padhiar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #222
Modifications
Introduces Gauge metrics called numaflow_isbservice_paused_seconds and numaflow_controller_paused_seconds which reports the total time an ISBService or NumaflowController is requesting resources be paused when it is updating. This is in line with the previously added PipelineRollout pause metrics that we emit these when dataLossPrevention flag is set to True.
We add the PauseStatus struct to both the ISBService and NumaflowController Rollouts however we have changed the JSON name to
pauseRequestStatusas we don't want users to assume the ISBService or controller themselves are being paused.Verification
Manually testing the changes by continuously updating NumaflowController and ISBServiceRollouts with dataLossPrevention enabled to examine the pause seconds are accurate.
(no unit testing now as we don't have dataLossPrevention enabled in those cases)