feat: add numaflow controller definition for v1.3.0 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dillen Padhiar <[email protected]>
Signed-off-by: Dillen Padhiar <[email protected]>
vigith
reviewed
Aug 20, 2024
| - controller | ||
| env: | ||
| - name: NUMAFLOW_IMAGE | ||
| value: quay.io/numaproj/numaflow:1.3.0-rc1 |
There was a problem hiding this comment.
Suggested change
| value: quay.io/numaproj/numaflow:1.3.0-rc1 | |
| value: quay.io/numaproj/numaflow:1.3.0 |
we have released 1.3.0
There was a problem hiding this comment.
Do you want to replace that here @dpadhiar ?
There was a problem hiding this comment.
Updated now to use image v1.3.0
|
I think the way to verify this is to create your sample NumaflowControllerRollout and then the other Rollouts, and make sure everything gets created successfully. (and no weird errors in Numaflow log) |
Signed-off-by: Dillen Padhiar <[email protected]>
dpadhiar
changed the title
xdevxy
approved these changes
Aug 20, 2024
juliev0
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Adding the controller definition for
v1.3.0which is the most recent Numaflow version that includes monovertices.Verification
Ran
make startto update local cm andmake testto verify tests still work using this definition.Created sample rollouts to see that the resources were created and functioned properly using this new definition.