chore: remove numaflow-controller-definition config #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hao Hao <[email protected]>
juliev0
approved these changes
Jul 17, 2024
afugazzotto
approved these changes
Jul 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=======================================
Coverage 52.92% 52.92%
=======================================
Files 15 15
Lines 1521 1521
=======================================
Hits 805 805
Misses 593 593
Partials 123 123 ☔ View full report in Codecov by Sentry. |
darshansimha
referenced
this pull request
in darshansimha/numaplane
Jul 19, 2024
Signed-off-by: Hao Hao <[email protected]> Signed-off-by: dsimha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
This PR removes the numaflow-controller-definition config from generated installation manifests as user should add based on their needs.
Verification
make manifests