fix: set max decode size of proto message (#2275)

Signed-off-by: Yashash H L <[email protected]> Co-authored-by: Yashash H L <[email protected]>
numaproj · Dec 12, 2024 · fea792b · fea792b
1 parent 346f2a7
commit fea792b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/rust/numaflow-core/src/monovertex.rs b/rust/numaflow-core/src/monovertex.rs
@@ -59,7 +59,7 @@ pub(crate) async fn start_forwarder(
         let mut source_grpc_client =
             SourceClient::new(create_rpc_channel(source_config.socket_path.clone().into()).await?)
                 .max_encoding_message_size(source_config.grpc_max_message_size)
-                .max_encoding_message_size(source_config.grpc_max_message_size);
+                .max_decoding_message_size(source_config.grpc_max_message_size);
 
         wait_until_source_ready(&cln_token, &mut source_grpc_client).await?;
         Some(source_grpc_client)
@@ -92,7 +92,7 @@ pub(crate) async fn start_forwarder(
         let mut sink_grpc_client =
             SinkClient::new(create_rpc_channel(udsink_config.socket_path.clone().into()).await?)
                 .max_encoding_message_size(udsink_config.grpc_max_message_size)
-                .max_encoding_message_size(udsink_config.grpc_max_message_size);
+                .max_decoding_message_size(udsink_config.grpc_max_message_size);
 
         wait_until_sink_ready(&cln_token, &mut sink_grpc_client).await?;
         Some(sink_grpc_client)
@@ -125,7 +125,7 @@ pub(crate) async fn start_forwarder(
                 create_rpc_channel(fb_sink_config.socket_path.clone().into()).await?,
             )
             .max_encoding_message_size(fb_sink_config.grpc_max_message_size)
-            .max_encoding_message_size(fb_sink_config.grpc_max_message_size);
+            .max_decoding_message_size(fb_sink_config.grpc_max_message_size);
 
             wait_until_sink_ready(&cln_token, &mut fb_sink_grpc_client).await?;
             Some(fb_sink_grpc_client)
@@ -164,7 +164,7 @@ pub(crate) async fn start_forwarder(
                 create_rpc_channel(transformer_config.socket_path.clone().into()).await?,
             )
             .max_encoding_message_size(transformer_config.grpc_max_message_size)
-            .max_encoding_message_size(transformer_config.grpc_max_message_size);
+            .max_decoding_message_size(transformer_config.grpc_max_message_size);
 
             wait_until_transformer_ready(&cln_token, &mut transformer_grpc_client).await?;
             Some(transformer_grpc_client.clone())

diff --git a/rust/numaflow-core/src/pipeline.rs b/rust/numaflow-core/src/pipeline.rs
@@ -244,7 +244,7 @@ async fn create_source_type(
                 create_rpc_channel(udsource_config.socket_path.clone().into()).await?,
             )
             .max_encoding_message_size(udsource_config.grpc_max_message_size)
-            .max_encoding_message_size(udsource_config.grpc_max_message_size);
+            .max_decoding_message_size(udsource_config.grpc_max_message_size);
             wait_until_source_ready(&cln_token, &mut source_grpc_client).await?;
             let (ud_read, ud_ack, ud_lag) = new_source(
                 source_grpc_client.clone(),
@@ -279,7 +279,7 @@ async fn create_transformer(
                 create_rpc_channel(ud_transformer.socket_path.clone().into()).await?,
             )
             .max_encoding_message_size(ud_transformer.grpc_max_message_size)
-            .max_encoding_message_size(ud_transformer.grpc_max_message_size);
+            .max_decoding_message_size(ud_transformer.grpc_max_message_size);
             wait_until_transformer_ready(&cln_token, &mut transformer_grpc_client).await?;
             return Ok((
                 Some(SourceTransformHandle::new(transformer_grpc_client.clone()).await?),

diff --git a/rust/numaflow-core/src/shared/utils.rs b/rust/numaflow-core/src/shared/utils.rs
@@ -191,7 +191,7 @@ pub(crate) async fn create_sink_handle(
             let mut sink_grpc_client =
                 SinkClient::new(create_rpc_channel(ud_config.socket_path.clone().into()).await?)
                     .max_encoding_message_size(ud_config.grpc_max_message_size)
-                    .max_encoding_message_size(ud_config.grpc_max_message_size);
+                    .max_decoding_message_size(ud_config.grpc_max_message_size);
             wait_until_sink_ready(cln_token, &mut sink_grpc_client).await?;
             // TODO: server info?