-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automate docker build and push + fix broken examples #62
Conversation
Signed-off-by: a3hadi <[email protected]>
Before implementing this for the rest of the examples as well as the script, I just wanted to check if it was ok to use local references in the rust sdk. I think it is fine for now since we have not published a crate, however I came across this: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#local-paths-in-published-crates. So what exactly would be the plan once we publish a crate? |
# copy your source tree | ||
COPY src ./src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might copy unwanted files, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I guess rather than copy the entire root directory with COPY ./ ./,
the only necessary things necessary to copy over would be src/, proto/, Cargo.toml, and build.rs? Is there anything else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for examples, we do not require proto, build.rs, etc., right?
Examples are not published, an example from a popular crate https://github.com/tokio-rs/axum/blob/main/examples/hello-world/Cargo.toml#L8 |
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge only after @KeranYang approves
LGTM. I am merging it. Will monitor the auto build push. |
No description provided.