Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automate docker build and push + fix broken examples #62

Merged
merged 14 commits into from
Jul 5, 2024

Conversation

ayildirim21
Copy link
Member

No description provided.

@ayildirim21 ayildirim21 marked this pull request as ready for review June 27, 2024 02:32
@ayildirim21 ayildirim21 marked this pull request as draft June 27, 2024 02:33
@ayildirim21
Copy link
Member Author

Before implementing this for the rest of the examples as well as the script, I just wanted to check if it was ok to use local references in the rust sdk. I think it is fine for now since we have not published a crate, however I came across this: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#local-paths-in-published-crates. So what exactly would be the plan once we publish a crate?

Comment on lines -9 to -10
# copy your source tree
COPY src ./src
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might copy unwanted files, right?

Copy link
Member Author

@ayildirim21 ayildirim21 Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I guess rather than copy the entire root directory with COPY ./ ./, the only necessary things necessary to copy over would be src/, proto/, Cargo.toml, and build.rs? Is there anything else?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for examples, we do not require proto, build.rs, etc., right?

@KeranYang KeranYang requested a review from yhl25 June 27, 2024 15:00
@vigith
Copy link
Member

vigith commented Jun 27, 2024

Before implementing this for the rest of the examples as well as the script, I just wanted to check if it was ok to use local references in the rust sdk. I think it is fine for now since we have not published a crate, however I came across this: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#local-paths-in-published-crates. So what exactly would be the plan once we publish a crate?

Examples are not published, an example from a popular crate https://github.com/tokio-rs/axum/blob/main/examples/hello-world/Cargo.toml#L8

@ayildirim21 ayildirim21 changed the title feat: automate docker build and push feat: automate docker build and push + fix broken examples Jul 2, 2024
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
@ayildirim21 ayildirim21 marked this pull request as ready for review July 3, 2024 18:58
Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge only after @KeranYang approves

@KeranYang
Copy link
Member

LGTM. I am merging it. Will monitor the auto build push.

@KeranYang KeranYang merged commit 6a33ad8 into numaproj:main Jul 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants