chore: sideInput example #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham dixit <[email protected]>
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
Signed-off-by: shubham <[email protected]>
vigith
reviewed
Dec 11, 2023
examples/sideinput-udf/src/main.rs
Outdated
| use tonic::{async_trait}; | ||
| use tokio::spawn; | ||
|
|
||
| const DIR_PATH: &str = "/var/run/numaflow/sideinput.sock"; |
There was a problem hiding this comment.
why are we watching on .sock file? that file is for the UDS socket.
There was a problem hiding this comment.
I forgot to push the changes ,updated the path now
Signed-off-by: shubham <[email protected]>
|
could you please run this locally and make sure it is working? |
vigith
approved these changes
Dec 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.