-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement update script and build/push workflow #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change. I left some comments. Also, how was this change tested? and can we fix the snyk security scan failure?
you can set it to v0.0.0
|
If we set to v0.0.0 then in the logs when we print out server info the version that is shown will also be v0.0.0. Would it be better if developers use the script to update the version when they want so it is accurately reflected in the logs? |
57ae74e
to
18f636c
Compare
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Co-authored-by: Keran Yang <[email protected]> Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
18f636c
to
f51a81b
Compare
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
I dont have access to snyk so cannot tell why the failures are occuring, but im pretty sure it has something to do with the fact that we modified the go.mod/go.sum files In terms of testing, I tested the script locally and it seems to be working as expected. For the workflow once we add the repo secrets (quay.io username and password) i will change the workflow to be triggered on push to see if the images are built and pushed correctly. |
ah, server-info will have the wrong version. good point :) |
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Signed-off-by: a3hadi <[email protected]>
Improve the CI of SDK as per #1363