New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve payment means with UNCL4461 #63

Open

TSimkus wants to merge 2 commits into num-num:master from TSimkus:improve-payment-means-with-UNCL4461

TSimkus commented Jan 22, 2024

Changes:

Added full list of UNCL4461 (Payment Means) codes.
Updated <cac:PaymentMeans> use UNCL4461 codes
Updated ->setPaymentMeansCode() to take string instead of int
Updated ->getPaymentMeansCode() to return string instead of int
Updated unit test to use UNCL4461 codes

This is an extension for PR#54

TSimkus added 2 commits

January 22, 2024 21:05


          Add list of payment means codes (UNCL4461)

a58a0f7


          Update unit test EN16931Test to use UNCL4461

8ec1270

TecsiAron commented Jan 23, 2024

A lot more elegant than my hack, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet