Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cac:AllowanceCharge in cac:InvoiceLine #58

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TSimkus
Copy link

@TSimkus TSimkus commented Jan 18, 2024

Adds support for cac:AllowanceCharge in cac:InvoiceLine.

Satisfying: https://docs.peppol.eu/poacc/billing/3.0/syntax/ubl-invoice/cac-InvoiceLine/cac-AllowanceCharge/

E-invoice is enforced in Romania and this tag is required there.

@TSimkus TSimkus changed the title Add support for cac:AllowanceCharge in InvoiceLine Add support for cac:AllowanceCharge in cac:InvoiceLine Jan 18, 2024
@TSimkus
Copy link
Author

TSimkus commented Jan 22, 2024

Previously I allowed only one instance of <cac:AllowanceCharge> to be displayed in <cac:InvoiceLine>.
However, that was a mistake.
Multiple instances of <cac:AllowanceCharge> must be allowed in <cac:InvoiceLine>.
My latest commit fixes that issue.

@KarelBrijs
Copy link

KarelBrijs commented Apr 13, 2024

@TSimkus FYI: You can use the Price object to add AllowanceCharge, however you can only add 1. There is no need to change InvoiceLine. A change inside Price would be nice to accommodate for multiple AllowanceCharge objects onto the Price object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants