Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C294 intro autogen subdomains #9

Merged
merged 4 commits into from
Apr 23, 2021
Merged

Conversation

ssickles
Copy link
Member

This PR adds a new provider called data_subdomain. It's purpose is to fetch the subdomain from furion so that when a subdomain module is executing it knows what dns_name to use. This will allow subdomain modules to use the dns_name that was configured when the subdomain was created as opposed to having to have the user re-enter it for every promotion.

@ssickles ssickles requested a review from BSick7 April 22, 2021 12:53
Copy link
Contributor

@BSick7 BSick7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@ssickles ssickles merged commit 7b26ec6 into main Apr 23, 2021
@BSick7 BSick7 deleted the C294-intro-autogen-subdomains branch April 23, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants