Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ssh command in beanstalk apps #179

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Add support for ssh command in beanstalk apps #179

merged 4 commits into from
Jan 16, 2024

Conversation

BSick7
Copy link
Contributor

@BSick7 BSick7 commented Jan 16, 2024

This PR adds support for beanstalk apps in the ssh and exec commands.
Since beanstalk apps have dynamic EC2 instances, I added a flag --instance to these commands, allowing a user to select a specific instance to SSH into. If not specified, the CLI will select a random instance.

The necessary changes to permissions and module outputs can be tracked here: nullstone-modules/aws-beanstalk-app#11

@BSick7 BSick7 requested a review from ssickles January 16, 2024 14:52
Copy link
Member

@ssickles ssickles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one comment to consider with regards to the documentation of the "instance" flag.

cmd/flag_ssh.go Outdated Show resolved Hide resolved
@BSick7 BSick7 merged commit 0f7d8e8 into master Jan 16, 2024
@BSick7 BSick7 deleted the beanstalk-ssh branch January 16, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants