Upgrade to windows-sys crate

[ssrlive]

No description provided.

[TroyNeubauer]

Thanks for this! Some minor comments

[thomaseizinger]

Thank you for updating this dependency! Is there something one can do to move this forward?

[TroyNeubauer]

I'll jump in and get this through

[ssrlive]

Hi @TroyNeubauer , since you lack the time and mind to maintain this project, could you add me as a co-contributor and publisher to this project? Or transfer to me?

[TroyNeubauer]

Open to do that at some point in the future. For the purposes of this PR, I would prefer you to respond to my feedback and then we can merge and release as usual

[ssrlive]

Hi @TroyNeubauer, I have switched to windows-sys crate for stability reason and fixed a bug about SetInterfaceDnsSettings function.

[TroyNeubauer]

Thanks for your work on this. Almost there!

I still have some open questions about removing logging and memory safety.

What are the specific reasons for switching to windows-sys? I see this as a significant readability decrease in our code since we have to handle low-level pointer details that the windows crate previously handled for us

[ssrlive]

Because each version of the windows crate makes completely incompatible changes to the API provided to users,
this forces users to spend a considerable amount of effort on unnecessary code modifications to adapt to the new version.

For example, the definition of HANDLE, has changed from

pub struct HANDLE(pub isize);

to

pub struct HANDLE(pub *mut core::ffi::c_void);

This is completely unacceptable.

The windows-sys crate, on the other hand, simply translates C-style APIs directly into Rust language, with no changing data structure definitions. Therefore, using it greatly benefits code stability.

What are the specific reasons for switching to windows-sys? I see this as a significant readability decrease in our code since we have to handle low-level pointer details that the windows crate previously handled for us

[thomaseizinger]

The windows-sys crate, on the other hand, simply translates C-style APIs directly into Rust language, with no changing data structure definitions. Therefore, using it greatly benefits code stability.

It still tracks the same version number though, right? i.e. windows-sys bumps its minor version in lockstep with windows (or the other way round I guess). You'd expect a -sys crate to be more stable but unfortunately, that doesn't seem to be the case with the Windows one.

[ssrlive]

Since unexpected issues might occur regardless of which crate we use, let's choose a crate that appears relatively reliable. Right? @thomaseizinger

[thomaseizinger]

My primary interest in this PR is to reduce the number of different versions of windows and windows-sys in our dependency tree.

I just realised that windows-sys indeed has less version churn! It just updates to the matching windows version when it does get bumped: https://crates.io/crates/windows-sys/versions

With this in mind, I support the use of windows-sys instead of windows.

[TroyNeubauer]

Nice find! Seems reasonable enough

[TroyNeubauer]

Will release shortly after some testing

[TroyNeubauer]

Released as v0.5.0. Thanks again!