Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interfacing with Python, part 2 #47

Merged
merged 13 commits into from
May 19, 2021
Merged

Conversation

fjarri
Copy link
Contributor

@fjarri fjarri commented Apr 22, 2021

Based on top of #45

Bringing Rust in sync with nucypher/pyUmbral#267

  • added Signer class
  • exposed Signature class with recovery_flag() method
  • take signer instead of a secret key in generate_kfrags()
  • split SerializableToArray into serialization and deserialization traits - some types (like verified kfrags and cfrags) can only be serialized.
  • implemented the new forced verification scheme for kfrags and cfrags
  • exposed CurvePoint and CurveScalar (since they are returned by verification_kit(), and exposed as fields as well)
  • added CapsuleFrag.verification_kit()
  • exposed Capsule and CapsuleFrag fields for verification purposes
  • added CurvePoint.to_affine() returning a pair of serializable coordinates
  • bumped dependencies, and set MSRV=1.51 (bounded by heapless)

@fjarri fjarri added Python Related to Python bindings API Related to public API labels Apr 22, 2021
@fjarri fjarri added this to the v0.1.0 milestone Apr 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

Merging #47 (81bc70f) into master (d70d6ae) will decrease coverage by 0.38%.
The diff coverage is 89.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   94.98%   94.59%   -0.39%     
==========================================
  Files          11       11              
  Lines         777      814      +37     
==========================================
+ Hits          738      770      +32     
- Misses         39       44       +5     
Impacted Files Coverage Δ
umbral-pre/src/dem.rs 92.50% <ø> (ø)
umbral-pre/src/traits.rs 96.42% <ø> (ø)
umbral-pre/src/capsule_frag.rs 94.48% <81.08%> (-0.60%) ⬇️
umbral-pre/src/key_frag.rs 88.50% <83.33%> (-0.74%) ⬇️
umbral-pre/src/hashing_ds.rs 92.00% <87.50%> (-8.00%) ⬇️
umbral-pre/src/capsule.rs 99.06% <100.00%> (+0.02%) ⬆️
umbral-pre/src/curve.rs 94.11% <100.00%> (+2.11%) ⬆️
umbral-pre/src/hashing.rs 97.14% <100.00%> (-0.73%) ⬇️
umbral-pre/src/keys.rs 95.87% <100.00%> (+0.52%) ⬆️
umbral-pre/src/pre.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d70d6ae...81bc70f. Read the comment docs.

@fjarri fjarri force-pushed the interfacing-2 branch 3 times, most recently from bdb6728 to beaba09 Compare April 23, 2021 04:30
@fjarri fjarri requested review from tuxxy and piotr-roslaniec April 24, 2021 07:15
@fjarri fjarri requested review from jMyles and vepkenez April 25, 2021 04:39
@fjarri fjarri changed the title [WIP] Interfacing with Python, part 2 Interfacing with Python, part 2 Apr 25, 2021
@fjarri fjarri mentioned this pull request May 5, 2021
@fjarri fjarri force-pushed the interfacing-2 branch 2 times, most recently from 6efbb92 to 1896da3 Compare May 5, 2021 21:35
Copy link
Contributor

@piotr-roslaniec piotr-roslaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@fjarri
Copy link
Contributor Author

fjarri commented May 17, 2021

I'll wait a little before merging pending the results of today's meeting. It may be possible we don't need the Adjudicator-specific API after all.

@fjarri fjarri force-pushed the interfacing-2 branch 5 times, most recently from b9edd24 to ee26f76 Compare May 18, 2021 23:28
Fixes a problem in CI with tarpaulin
@fjarri fjarri merged commit 3cba902 into nucypher:master May 19, 2021
@fjarri fjarri deleted the interfacing-2 branch May 19, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to public API Python Related to Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants