-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove local maindb driver #2636
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2636 +/- ##
==========================================
+ Coverage 86.19% 86.51% +0.32%
==========================================
Files 377 376 -1
Lines 23776 23602 -174
==========================================
- Hits 20493 20419 -74
+ Misses 3283 3183 -100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
import pytest | ||
import requests | ||
from pytest_docker_fixtures import images # type: ignore | ||
from pytest_docker_fixtures.containers._base import BaseImage # type: ignore | ||
|
||
import nucliadb_sdk | ||
|
||
images.settings["postgresql"]["version"] = "11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think nidx needs v13, maybe we can already use that
Description
We remove the local implementation of the maindb driver for the following reasons:
This will allow us to:
How was this PR tested?
Existing tests should cover us. I'm just removing code