Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nidx dev deploy #2632

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Nidx dev deploy #2632

merged 4 commits into from
Nov 15, 2024

Conversation

javitonino
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.10%. Comparing base (1a25d0d) to head (1cc7381).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
nucliadb/src/nucliadb/common/nidx.py 89.65% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2632      +/-   ##
==========================================
- Coverage   86.13%   86.10%   -0.03%     
==========================================
  Files         377      377              
  Lines       23861    23841      -20     
==========================================
- Hits        20553    20529      -24     
- Misses       3308     3312       +4     
Flag Coverage Δ
nucliadb 73.37% <43.90%> (-0.10%) ⬇️
nucliadb-ingest 28.63% <26.82%> (+0.04%) ⬆️
nucliadb-reader 24.66% <19.51%> (+0.02%) ⬆️
nucliadb-search 37.96% <75.60%> (+0.06%) ⬆️
nucliadb-standalone 46.63% <26.82%> (+0.03%) ⬆️
nucliadb-train 44.74% <31.70%> (+<0.01%) ⬆️
nucliadb-writer 39.19% <19.51%> (+0.02%) ⬆️
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 84.82% <ø> (-0.16%) ⬇️
nucliadb_sdk 80.11% <ø> (ø)
nucliadb_sidecar 89.03% <ø> (ø)
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 84.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javitonino javitonino force-pushed the nidx_dev_deploy branch 3 times, most recently from 8a29dfa to a2d110c Compare November 14, 2024 14:06
@javitonino javitonino merged commit 11a5e93 into dev Nov 15, 2024
47 checks passed
@javitonino javitonino deleted the nidx_dev_deploy branch November 15, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants