Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running search cluster tests with nidx #2627

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Conversation

javitonino
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.94%. Comparing base (bf98cc8) to head (63a0c1b).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2627      +/-   ##
==========================================
- Coverage   85.96%   85.94%   -0.03%     
==========================================
  Files         377      377              
  Lines       23864    23866       +2     
==========================================
- Hits        20515    20511       -4     
- Misses       3349     3355       +6     
Flag Coverage Δ
nucliadb 73.45% <100.00%> (-0.08%) ⬇️
nucliadb-ingest 28.53% <0.00%> (-0.01%) ⬇️
nucliadb-reader 24.58% <0.00%> (-0.01%) ⬇️
nucliadb-search 37.64% <100.00%> (+0.01%) ⬆️
nucliadb-standalone 46.56% <100.00%> (+<0.01%) ⬆️
nucliadb-train 44.69% <100.00%> (+<0.01%) ⬆️
nucliadb-writer 39.09% <0.00%> (-0.01%) ⬇️
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 84.82% <ø> (ø)
nucliadb_sdk 80.11% <ø> (ø)
nucliadb_sidecar 89.03% <ø> (+1.78%) ⬆️
nucliadb_telemetry 86.55% <ø> (ø)
nucliadb_utils 84.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javitonino javitonino merged commit 785e912 into dev Nov 13, 2024
42 checks passed
@javitonino javitonino deleted the nidx_binding_for_tests branch November 13, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants