Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist proxied headers when proxing to learning services #1909

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Mar 5, 2024

Description

How was this PR tested?

Existing unit tests and local tests

@lferran lferran requested a review from a team March 5, 2024 10:25
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.90%. Comparing base (43ad71e) to head (6d1e009).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1909   +/-   ##
=======================================
  Coverage   83.90%   83.90%           
=======================================
  Files         328      328           
  Lines       18674    18674           
=======================================
  Hits        15669    15669           
  Misses       3005     3005           
Flag Coverage Δ
ingest 68.81% <ø> (ø)
sdk 87.85% <ø> (ø)
utils 81.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran merged commit de3f845 into main Mar 5, 2024
71 checks passed
@lferran lferran deleted the whitelist-proxied-headers branch March 5, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants