Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean broken address data #77

Merged
merged 1 commit into from
Aug 8, 2020
Merged

Clean broken address data #77

merged 1 commit into from
Aug 8, 2020

Conversation

core23
Copy link
Member

@core23 core23 commented Aug 8, 2020

Subject

Remove zip code information from city name.

There are some events on Last.fm that contain invalid address data, e.g. the zip code is entered as a city name (https://www.last.fm/festival/4548967+Under+the+Black+Sun).

@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

Merging #77 into main will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #77      +/-   ##
============================================
- Coverage     25.85%   25.79%   -0.07%     
- Complexity      632      635       +3     
============================================
  Files            53       53              
  Lines          1690     1694       +4     
============================================
  Hits            437      437              
- Misses         1253     1257       +4     
Impacted Files Coverage Δ Complexity Δ
src/Crawler/EventInfoCrawler.php 0.00% <0.00%> (ø) 11.00 <0.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f4f9ea...cf5552a. Read the comment docs.

@core23 core23 force-pushed the fix-address-crawler branch from 950af3b to d2d56f4 Compare August 8, 2020 08:07
@core23 core23 force-pushed the fix-address-crawler branch from d2d56f4 to cf5552a Compare August 8, 2020 08:18
@kodiakhq kodiakhq bot merged commit e54363a into main Aug 8, 2020
@kodiakhq kodiakhq bot deleted the fix-address-crawler branch August 8, 2020 08:20
@core23 core23 removed the automerge label Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant