feat(JAQPOT-135): Update MeanVar #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d2abf6f.
Deleted calculate() method because it is already replaced by predict()
This commit refactors the structure of `DOA` to be an abstract base class. Additionally, `Leverage` and `MeanVar` inherit from `DOA`.
vassilismin
changed the title
MeanVarMeanVar
vassilismin
changed the title
MeanVar
vassilismin
changed the title
alarv
approved these changes
Jun 13, 2024
jaqpotpy/doa/doa.py
Outdated
Comment on lines
136
to
137
| # self._doa_matrix = None | ||
| # self._a = None |
There was a problem hiding this comment.
delete those 2 lines since they're not used anymore.
Deleted some comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
DOAclass as an ABC classMeanVar()doa method