Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: torchscript_and_onnx #20

Merged
merged 2 commits into from
Sep 26, 2024
Merged

feat: torchscript_and_onnx #20

merged 2 commits into from
Sep 26, 2024

Conversation

johnsaveus
Copy link
Contributor

Created different handlers for onnx model and torchscript model

alarv
alarv requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@alarv alarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before you merge this you have to:

  1. Release jaqpotpy (I can explain how to do that)
  2. After releasing, change the version of jaqpotpy here in the requirements.txt and then you can merge

@johnsaveus johnsaveus requested a review from alarv September 26, 2024 07:26
alarv
alarv approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@alarv alarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@johnsaveus johnsaveus merged commit 39e08dd into main Sep 26, 2024
2 checks passed
@johnsaveus johnsaveus deleted the feat/JAQPOT-321/Inference_for_torch branch September 26, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vassilismin vassilismin vassilismin approved these changes

@alarv alarv alarv approved these changes

@periklis91 periklis91 Awaiting requested review from periklis91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnsaveus @alarv @vassilismin