Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version initial run and auto config error #593

Closed
CyberBitz opened this issue Jun 23, 2021 · 6 comments
Closed

Latest version initial run and auto config error #593

CyberBitz opened this issue Jun 23, 2021 · 6 comments
Labels
bug Something isn't working next release Implemented but will be released with the next release

Comments

@CyberBitz
Copy link

CyberBitz commented Jun 23, 2021

First time, downloaded and ran with auto setup, I am getting this error:

Describe the bug
Initialized the autoconfig and this is the error after it runs

Loaded config: C:..........\BGPMonitor\config.yml
BGPalerter, version: 1.28.0 environment: production
TypeError: Cannot read property 'length' of null
at AS.isValid (C:\snapshot\BGPalerter\dist\src\model.js:142:36)
at new AS (C:\snapshot\BGPalerter\dist\src\model.js:118:14)
at C:\snapshot\BGPalerter\dist\src\inputs\inputYml.js:161:64
at Array.map ()
at _loop (C:\snapshot\BGPalerter\dist\src\inputs\inputYml.js:149:92)
at C:\snapshot\BGPalerter\dist\src\inputs\inputYml.js:194:24
at new Promise ()
at InputYml._loadPrefixes (C:\snapshot\BGPalerter\dist\src\inputs\inputYml.js:109:14)
at InputYml.loadPrefixes (C:\snapshot\BGPalerter\dist\src\inputs\inputYml.js:79:20)
at Timeout._onTimeout (C:\snapshot\BGPalerter\dist\src\inputs\input.js:377:11)

Provide an example
Provide an example in terms of prefixes and BGP messages. Possibly provide a snippet of config.yml and prefixes.yml.

Expected behavior
provide an output that does not result in an error

Are you using the binary or the source code?
I downloaded the bgpalerter-win-x64.exe

Your information
Thomas Jenkins

@CyberBitz CyberBitz added the bug Something isn't working label Jun 23, 2021
@massimocandela
Copy link
Member

From the error it looks like a config file is corrupted. Possibly an AS number in prefixes.yml.
I cannot reproduce the issue without more information: please, when opening an issue, don't wipe the bug report template.

@CyberBitz
Copy link
Author

Thanks, I will run a few tests and post the configs

@CyberBitz
Copy link
Author

CyberBitz commented Jun 23, 2021

This is with the 10421 AS. I changed the extension from yml to log for uploading
config.log

prefixes.log

The error log file contains:
2021-06-23T16:28:51-03:00 info: ris connector connected
2021-06-23T19:31:20+00:00 info: ris connector connected
2021-06-23T19:32:18+00:00 info: ris connector connected
2021-06-23T19:54:07+00:00 info: ris connector connected
2021-06-23T20:11:50+00:00 info: ris connector connected
2021-06-23T20:21:16+00:00 error: TypeError: Cannot read property 'length' of null

@massimocandela
Copy link
Member

Thanks! I was able to reproduce it with your prefixes.yml. I made a patch that improves the validation of the prefixes.yml file, in particular the new downstreams/upstreams part.

Please, replace your executable with the one of v1.28.1. Let me know if you have any other problem.

Thanks for reporting.

@CyberBitz
Copy link
Author

Awesome, thanks.

@massimocandela massimocandela added the next release Implemented but will be released with the next release label Jun 23, 2021
@massimocandela
Copy link
Member

For whoever else has this issue with v1.28.0: open prefixes.yml and remove the "[]" in the downtreams/upstreams section

@massimocandela massimocandela mentioned this issue Jun 24, 2021
massimocandela added a commit that referenced this issue Jun 24, 2021
fixed crash on malformed list of downstream/upstream ASes (#593)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next release Implemented but will be released with the next release
Projects
None yet
Development

No branches or pull requests

2 participants