Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/add quick start to readme #536

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Conversation

nitky
Copy link
Collaborator

@nitky nitky commented Dec 17, 2024

PR の目的

Threatconnectomeを簡単に試す手順を追加。

経緯・意図・意思決定

クイックスタート用のスクリプトが追加されたので、その使い方をREADMEに追加しました。

参考文献

@dejima-shikou
Copy link
Collaborator

シンプルに書くべきとは思いますが、
demo_stop.sh のことも書いておいた方が良いと思います。

@nitky
Copy link
Collaborator Author

nitky commented Dec 17, 2024

終了方法の追記と、クイックスタートのスクリプトメッセージの編集を実施しました🙏

Copy link
Collaborator

@mshim03 mshim03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshim03 mshim03 merged commit 3dbef93 into main Dec 17, 2024
3 checks passed
@mshim03 mshim03 deleted the topic/add-quick-start-to-readme branch December 17, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants