Drop Python 2 support and set 3.5 as the min version. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticied that this is listed as beta in the classifiers, so I think we can change that to "stable". |
|
Btw, there will be another PR coming soon (I might find some time tonight, otherwise it'd have to wait for next week) to fix an issue with the |
|
Ack (hello from Ghana 🇬🇭 ). Give me a kick via GitHub when the PRs are lined up and I'll press buttons to cut a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically speaking it closes #19 😅
But yeah, tests fail with Python 2.7 and 3.4 (as indicated in #30), so we should set the min version as 3.5 with
python_requires.