Added support and test for style attributes that are strings instead …

…of objects
ntharim · Jan 23, 2017 · 632d759 · 632d759
1 parent 6999583
commit 632d759
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 8 deletions.
diff --git a/create-attribute.js b/create-attribute.js
@@ -66,4 +66,4 @@ function memoizeString(callback) {
       return cache[string] = callback.call(this, string);
     }
   };
-}
+}
diff --git a/index.js b/index.js
@@ -60,12 +60,16 @@ function openTag(node) {
     }
 
     if (name == 'style') {
-      var css = '';
-      value = extend({}, value);
-      for (var styleProp in value) {
-        css += paramCase(styleProp) + ': ' + value[styleProp] + '; ';
+      if (typeof value === 'string') {
+        // do nothing, string style values are good as-is
+      } else {
+        var css = '';
+        value = extend({}, value);
+        for (var styleProp in value) {
+          css += paramCase(styleProp) + ': ' + value[styleProp] + '; ';
+        }
+        value = css.trim();
       }
-      value = css.trim();
     }
 
     if (value instanceof softHook || value instanceof attrHook) {

diff --git a/test/test.js b/test/test.js
@@ -56,7 +56,7 @@ describe('toHTML()', function () {
     assert.equal(toHTML(node), '<web-component></web-component>');
   });
 
-  it('should render CSS for style property', function () {
+  it('should render CSS for style property (if not a string)', function () {
     var node = new VNode('div', {
       style: {
         background: 'black',
@@ -66,7 +66,14 @@ describe('toHTML()', function () {
     assert.equal(toHTML(node), '<div style="background: black; color: red;"></div>');
   });
 
-  it('should convert style property to param-case', function () {
+  it('should render CSS for style property (if a string)', function () {
+    var node = new VNode('div', {
+      style: 'background: black; color: red;'
+    });
+    assert.equal(toHTML(node), '<div style="background: black; color: red;"></div>');
+  });
+
+  it('should convert style property to param-case (if not a string)', function () {
     var node = new VNode('div', {
       style: {
         background: 'black',
-Original file line number
+Diff line change
@@ Expand Up / @@ -66,4 +66,4 @@ function memoizeString(callback) { @@
           return cache[string] = callback.call(this, string);
         }
       };
-    }
+    }