Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sdist builds to find doc dependency lists #748

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

MSeal
Copy link
Member

@MSeal MSeal commented Nov 15, 2023

What does this PR do?

Moves the docs/requirements.txt to a place it is bundling with tar balls. (I tried a few setup options but it was really struggling to force include that other path).

Fixes #737

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #748 (d444b04) into main (7f25147) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #748   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files          17       17           
  Lines        1622     1622           
=======================================
  Hits         1484     1484           
  Misses        138      138           

Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MSeal 👍🏼

@willingc willingc enabled auto-merge (squash) November 18, 2023 05:21
@willingc willingc merged commit e3bf26b into nteract:main Nov 18, 2023
13 checks passed
@blink1073
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest release not installable from sdist
3 participants