Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip black formatting if it encounters an AttributeError #699

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

colindean
Copy link
Contributor

What does this PR do?

Skip black formatting if it encounters an AttributeError, potentially indicating a change in the Black public API, which doesn't really exist yet.

Fixes #698

@colindean
Copy link
Contributor Author

Is there anything I can do to help get this in? It's really frustrating for our builds to fail sporadically because of this.

@MSeal
Copy link
Member

MSeal commented Nov 29, 2022

Thanks for the capture, I'll look into if black had an api change as well

@MSeal MSeal enabled auto-merge (squash) November 29, 2022 15:08
@colindean
Copy link
Contributor Author

@MSeal Is there anything I can do to move this along/

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #699 (e8a39eb) into main (d5a986c) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
- Coverage   91.50%   91.39%   -0.12%     
==========================================
  Files          17       17              
  Lines        1625     1627       +2     
==========================================
  Hits         1487     1487              
- Misses        138      140       +2     
Files Coverage Δ
papermill/translators.py 97.86% <0.00%> (-0.53%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a986c...e8a39eb. Read the comment docs.

@MSeal MSeal merged commit c40813a into nteract:main Nov 1, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Papermill should continue when encountering AttributeError when using black
2 participants