Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NBConvert with NBClient #472

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Replace NBConvert with NBClient #472

merged 2 commits into from
Feb 11, 2020

Conversation

MSeal
Copy link
Member

@MSeal MSeal commented Feb 10, 2020

Waiting for the first release of https://github.com/jupyter/nbclient (which is waiting on a minumum of these 2 prs to merge: jupyter/nbclient#12 and jupyter/nbclient#17)

@MSeal MSeal changed the title [WIP] Replace NBConvert with NBClient Replace NBConvert with NBClient Feb 11, 2020
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #472 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   91.45%   91.42%   -0.04%     
==========================================
  Files          14       14              
  Lines        1229     1224       -5     
==========================================
- Hits         1124     1119       -5     
  Misses        105      105

Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MSeal MSeal merged commit 0abe8a2 into nteract:master Feb 11, 2020
@MSeal MSeal deleted the nbclient branch August 18, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants