Convert to TypeScript #2063
Merged
Convert to TypeScript #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` npm install -g @khanacademy/flow-to-ts flow-to-ts --write --delete-source ./lib/**/*.js ``` In `lib/services/status-bar/status-bar-component.tsx` @observer removed before the conversion and re-added after due to prettier error
aminya
force-pushed
the
typescript
branch
5 times, most recently
from
1da77e2
to
db9f792
Compare
aminya
force-pushed
the
typescript
branch
2 times, most recently
from
851d4ae
to
001da73
Compare
``` npm i -g install-types install-types ``` Then fixed the version
aminya
commented
Apr 10, 2021
|
@aminya I've been keeping an eye on this PR, so I could give you some comments (but not this weekend). PS: I haven't kept up to date with nteract's libraries. I won't be able to give you feedback on their use. |
|
Thanks. If you can just build and use this a bit, it would be enough. |
|
I am going to merge this for now as I want to make some other changes. You can test the functionality on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the codebase to TypeScript
Requires:
nteract/kernelspecs#35
nteract/jupyter-paths#39
The tests
The tests are all passing
https://github.com/aminya/hydrogen/actions/runs/733861352
How to test the functionality
Make sure to run
apm unlink .after you're done testing, so you don't miss the official versions.How to review
You can go through the commits which include the mental logic behind the changes.
The first commit conversion is done automatically using @khanacademy/flow-to-ts, and then the issues are fixed by hand.
If you want to verify the changes make sure to disable the whitespace changes generated by the tool.