Provide ordering to configuration settings #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenRussert
approved these changes
Feb 6, 2019
There was a problem hiding this comment.
Really great idea to clean this up, thanks! I will wait to merge until you see my comments on #1515.
|
If you are still up ping me on slack real quick @kylebarron, I can help you get this rebased cleanly. We could do that tomorrow if you are out for the night. |
|
I think after merging now-current master it'll pass tests and be fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hydrogen has grown to the point where there are 14 configuration settings. Currently, no ordering is provided, so I think they're ordered alphabetically in terms of the config key. I think this is more confusing than it has to be for users.
This PR attempts to group settings logically and then order them with the
ordervalue in the dictionary. The idea is "general settings" then "output settings" then "kernel settings", and within each ordered by most used to least used.The order is:
autocompleteshowAutocompleteFirststatusBarDisabledebugautoScrolloutputAreaDefaultoutputAreaDockoutputAreaFontSizeglobalModekernelNotificationsstartDirlanguageMappingsstartupCodegateways