Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class to status bar item #1389

Merged
merged 1 commit into from
Aug 25, 2018
Merged

Conversation

danielbayley
Copy link
Member

Add .hydrogen class to distinguish it and prevent clashing with other items in the status bar.

Add .hydrogen class to distinguish it and prevent clashing with other items in the status bar.
@BenRussert
Copy link
Member

Hi, sorry to leave you hanging here. It's harder for me to review styling PRs because I don't know what side effects there might be without trying it out.

Will this change anything for hydrogen? Or just make it more friendly to other status bar elements?

@danielbayley
Copy link
Member Author

I don't know what side effects there might be

@BenRussert All it does is add an extra class to the selector already under .status-bar; so I can't see how there could be any side effects… unless there is another package called hydrogen that puts things in the status bar with that class selector (and apm packages are namespaced…)

Or just make it more friendly to other status bar elements?

It changes absolutely nothing for Hydrogen… this is just so it will play nice with other packages that put things in the status bar. Everyone seems to use it as a dumping ground without any thought to what else is in there! The main reason for this PR is so Hydrogen doesn't mess up the order of thing in my status bar (using https://atom.io/packages/move-status-items).

@BenRussert BenRussert merged commit 6f895fa into nteract:master Aug 25, 2018
@BenRussert
Copy link
Member

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants