Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle filename changes #1217

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Handle filename changes #1217

merged 1 commit into from
Feb 8, 2018

Conversation

BenRussert
Copy link
Member

@BenRussert
Copy link
Member Author

This is a bit of a hack to handle this issue:

  1. Create a new untitled file ctrl+n
  2. Save that file ctrl+s
  3. Try to start a kernel, it will fail

The reason is that store.filePath is a mobx calculated value that will only recalculate when store.editor changes.

Open to suggestions if there is a better way to do this.

@rgbkrk
Copy link
Member

rgbkrk commented Feb 8, 2018

Seems like a fine workaround for now.

@rgbkrk rgbkrk merged commit 7b69423 into nteract:master Feb 8, 2018
@snyk-bot snyk-bot mentioned this pull request Feb 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hydrogen error in Atom
2 participants
@BenRussert @rgbkrk