-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on latest React, WeekdayPicker throws unknown prop errors for onTouchTap #13
Comments
@ntdb: the Wiki Ed Dashboard doesn't use the onTouchTap feature. Maybe it could be removed altogether, or conditionally assigned to the button only if present? Currently it breaks our Poltergeist tests when the front-end is built in development mode. |
@ntdb ping :-) |
@ragesoss I would be happy to merge and publish a PR! This library is pretty far out of date at this point and it's tough for me to keep up when I'm not using it regularly, sorry about that. The |
@ntdb thanks Nate! A PR was on my todo list, but if it's more broadly out of date, it'll probably make more sense to just copy it into the app and maintain it from there. What do you think? |
@ragesoss you totally have my blessing to do that. If I pick this library back up in the future I'll definitely look at what you're doing first. |
See ntdb/react-weekday-picker#13 This component was originally created for use in the dashboard, but had been maintained separately for possible use by others. It's now moved into the dashboard codebase.
After upgrading to React 15.4.1, I get this error whenever a WeekdayPicker renders:
The text was updated successfully, but these errors were encountered: