Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on latest React, WeekdayPicker throws unknown prop errors for onTouchTap #13

Open
ragesoss opened this issue Dec 5, 2016 · 5 comments

Comments

@ragesoss
Copy link

ragesoss commented Dec 5, 2016

After upgrading to React 15.4.1, I get this error whenever a WeekdayPicker renders:

       Warning: Unknown prop `onTouchTap` on <button> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
           in button (created by WeekdayPicker)
@ragesoss
Copy link
Author

@ntdb: the Wiki Ed Dashboard doesn't use the onTouchTap feature. Maybe it could be removed altogether, or conditionally assigned to the button only if present?

Currently it breaks our Poltergeist tests when the front-end is built in development mode.

@ragesoss
Copy link
Author

@ntdb ping :-)

@ntdb
Copy link
Owner

ntdb commented Apr 14, 2017

@ragesoss I would be happy to merge and publish a PR! This library is pretty far out of date at this point and it's tough for me to keep up when I'm not using it regularly, sorry about that. The react-day-picker repo this is based off of abandoned onTouchTap a while ago for onTouchStart and onTouchEnd.

@ragesoss
Copy link
Author

@ntdb thanks Nate! A PR was on my todo list, but if it's more broadly out of date, it'll probably make more sense to just copy it into the app and maintain it from there. What do you think?

@ntdb
Copy link
Owner

ntdb commented Apr 14, 2017

@ragesoss you totally have my blessing to do that. If I pick this library back up in the future I'll definitely look at what you're doing first.

ragesoss added a commit to WikiEducationFoundation/WikiEduDashboard that referenced this issue May 19, 2017
See ntdb/react-weekday-picker#13

This component was originally created for use in the dashboard, but had been maintained separately for possible use by others. It's now moved into the dashboard codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants