Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the provide() handling #4

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Improve the provide() handling #4

merged 1 commit into from
Jul 31, 2024

Conversation

JamesDPC
Copy link
Contributor

Changes

  • Add a context array parameter to provide() to allow some context, currently current SiteConfig value, to be passed to the chosen provider.
  • Some analytics providers do not require a analytics service code, do not block loading of the script if so
  • All current services require a identifier code to deliver a script

@JamesDPC
Improve the provide() handling by allowing a context to be passed as …
832311f 
…a parameter, by default the current site config is passed. Allow provide() to be called if there is no identifer code provided, as some implementations do not require a code
@JamesDPC JamesDPC requested a review from tardinha July 31, 2024 01:09
@JamesDPC JamesDPC self-assigned this Jul 31, 2024
@tardinha tardinha merged commit 0107fe6 into main Jul 31, 2024
@tardinha tardinha deleted the provide-improvements branch July 31, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tardinha tardinha tardinha approved these changes

Assignees

@JamesDPC JamesDPC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesDPC @tardinha