-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added draw_after argument to shinydrawr #14
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch, you hand edited bundled and transpiled javascript. I'm impressed. What was the goal of the changes to /libraries/youDrawIt.js
? I can make them in the main javascript and then re-bundle.
I need to figure out a better way to do this as I currently have a separate repo setup for javascript to bundle youDrawIt()
into a standalone javascript library, but it makes changing things javascript-side kinda lame.
This is where the main javascript function lives. |
We want to be able to draw the x-axis as dates and we want half of the data
and have a user draw data after a certain point ( a few weeks after in the
future) and we want to save the data out.
We want to plot separate lines for different groups (regions of a country),
so a way to functionize it with filter and the data.
In muschellij2/epi_click, there is a data generation in app.R
On Tue, Jul 18, 2017 at 8:24 PM Nick Strayer ***@***.***> wrote:
This <https://github.com/jhudsl/shinyDraw/blob/master/src/main.js> is
where the main javascript function lives.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABBnruylBH9v2lsLe1DG_TXdMwkQ3hQ8ks5sPUylgaJpZM4ORLOP>
.
--
John
|
Also - I was using shinysense because it had shiny backended with a module.
John
On Tue, Jul 18, 2017 at 8:42 PM, John Muschelli <[email protected]>
wrote:
… We want to be able to draw the x-axis as dates and we want half of the
data and have a user draw data after a certain point ( a few weeks after in
the future) and we want to save the data out.
We want to plot separate lines for different groups (regions of a
country), so a way to functionize it with filter and the data.
In muschellij2/epi_click, there is a data generation in app.R
On Tue, Jul 18, 2017 at 8:24 PM Nick Strayer ***@***.***>
wrote:
> This <https://github.com/jhudsl/shinyDraw/blob/master/src/main.js> is
> where the main javascript function lives.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#14 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABBnruylBH9v2lsLe1DG_TXdMwkQ3hQ8ks5sPUylgaJpZM4ORLOP>
> .
>
--
John
|
Should take care of #13 if you accept it.
I think this makes sense, but you may have a different vision for
raw_draw
.