Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling error in the "Parsing JSON is a Minefield 💣" article #134

Open
ChristanBeyond opened this issue Sep 26, 2024 · 4 comments
Open

Comments

@ChristanBeyond
Copy link

The article states:

You'll find more that 300 tests in the JSONTestSuite GitHub repository.

but it should be:

You'll find more than 300 tests in the JSONTestSuite GitHub repository.

@RokerHRO
Copy link

RokerHRO commented Sep 26, 2024

There are a lot more spelling errors, even distorting errors, e.g. in section 2.5 Strings, where the examples are wrong due to missing backslashes:

  • ["x00"] is totally valid, I guess the author meant ["\x00"] as an example for invalid string escape.
  • [""\/bfnrt"] is invalid, because two consecutive quote characters would describe an empty string, no additional characters are allowed. I guess the author wanted to write ["\"\/\b\f\n\r\t"]
  • ["uqqqq"] is valid, but no escape. I guess the author wanted to write ["\uqqqq"]

and many more such things. :-(

@ChristanBeyond
Copy link
Author

Would be nice if he gave the article an update again, it's overall a really good article, which helped quite a bit with the paper I'm writing.

@RokerHRO
Copy link

ACK, but I don't see much activity here in this repo, so I think the author is not interested in fixing his article or out of time at the moment. :-(

@nst
Copy link
Owner

nst commented Sep 26, 2024

Author here! Thank you so much for helping to improve the article. Indeed, escaping errors may be due to Markdown syntax. I'll upload the article to GitHub shortly so that you can submit pull requests.

nst added a commit that referenced this issue Sep 30, 2024
RokerHRO pushed a commit to RokerHRO/JSONTestSuite that referenced this issue Oct 13, 2024
ChristanVersteeg added a commit to ChristanVersteeg/JSONTestSuite that referenced this issue Oct 18, 2024
"You'll find more that 300 tests"
To
"You'll find more than 300 tests"
nst added a commit that referenced this issue Nov 7, 2024
nst added a commit that referenced this issue Nov 7, 2024
fix missing backslash escapes. #134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants