Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken typescript definition for addFilter; missing type? #90

Closed
ja11sop opened this issue Jul 26, 2020 · 0 comments · Fixed by #94
Closed

Broken typescript definition for addFilter; missing type? #90

ja11sop opened this issue Jul 26, 2020 · 0 comments · Fixed by #94

Comments

@ja11sop
Copy link

ja11sop commented Jul 26, 2020

The definition for addFilter in:
https://github.com/nspragg/filehound/blob/master/index.d.ts

is:

public addFilter(filter: (...any) => boolean): FileHound;

but this gives me a compile error:

Parameter has a name but no type. Did you mean 'arg0: any'? (ts7051)

I believe the definition should be changed to?

public addFilter(filter: (...any: any[]) => boolean): FileHound;
@ja11sop ja11sop mentioned this issue Aug 3, 2020
Closed
cspotcode added a commit to cspotcode/filehound that referenced this issue Mar 6, 2021
@cspotcode
Fix nspragg#90
7a01252
@cspotcode cspotcode mentioned this issue Mar 6, 2021
Merged
nspragg added a commit that referenced this issue Feb 1, 2022
@nspragg
Merge pull request #94 from cspotcode/patch-1
f29ab5a 
Fix #90
stefankuehnel added a commit to custom-recipes/prettier-imports that referenced this issue Dec 25, 2022
@stefankuehnel
fix(dependencies): update dependencies to fix backwards compatible bu…
6a1ecb4 
…g(s)

This commit updates the following dependencies to the latest patch
version that contains backwards compatible bug fixes:

  - filehound: from 1.17.5 to 1.17.6

  - @types/lodash.keyby: from 4.6.6 to 4.6.7

  - @types/lodash.keys: from 4.2.6 to 4.2.7

Bug fix details:

  - Fix issue in filehound that contained broken TypeScript
    definitions in 'addFilter' [1].

  - Fix issue in filehound that caused compilation errors in
    TypeScript when attempting to pass string[] to paths() [2].

Link: nspragg/filehound#90 [1]
Link: nspragg/filehound#91 [2]
Signed-off-by: Stefan Kühnel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #90 cspotcode/filehound
1 participant
@ja11sop