bearer: Improvements and test coverage #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Sep 18, 2024
cthulhu-rider
commented
- after session: Improvements and test coverage #612
cthulhu-rider
force-pushed
the
bearer
branch
from
393c5f9
to
f0018c8
Compare
Same as f17fc15. Signed-off-by: Leonard Lyubich <[email protected]>
Same as b9b920d. Signed-off-by: Leonard Lyubich <[email protected]>
Has been forgotten in 2cca6c7. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
bearer
branch
from
f0018c8
to
d1e6d97
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #626 +/- ##
==========================================
+ Coverage 54.19% 55.36% +1.16%
==========================================
Files 164 164
Lines 19191 19203 +12
==========================================
+ Hits 10401 10631 +230
+ Misses 8362 8183 -179
+ Partials 428 389 -39 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
requested review from
roman-khimov,
smallhive and
carpawell
as code owners
smallhive
reviewed
Sep 26, 2024
cthulhu-rider
force-pushed
the
bearer
branch
3 times, most recently
from
e0242b1
to
6ea9f9c
Compare
cthulhu-rider
force-pushed
the
bearer
branch
2 times, most recently
from
b4abd08
to
83bfa4a
Compare
smallhive
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Looks like 2a37283 does much more than expected from its message.
cthulhu-rider
force-pushed
the
bearer
branch
from
83bfa4a
to
4303331
Compare
|
oops rebase sheet, fixed |
Bearer token type provides `EACLTable` method to access underlying eACL. It states that if the table is unset, zero instance is returned. The problem is that `eacl.Table` type did not implement `comparable` constraint. So, there is no way to check whether eACL instance is zero or not. Therefore, there was no way to find out whether the token contained a table. This adds `eacl.Table.IsZero` method allowing to check the eACL presence. Currently, it covers all cases where table is required incl. bearer tokens. Signed-off-by: Leonard Lyubich <[email protected]>
Signed-off-by: Leonard Lyubich <[email protected]>
Previously, bearer and session token types provided `InvalidAt` method checking whether the token is invalid at the given epoch. This was not a very good choice, since users are more naturally inclined to work with affirmative methods. In this case, the validity check, not the invalidity one. This extends interface of NeoFS tokens with `ValidAt` method. `InvalidAt` ones are marked deprecated. Signed-off-by: Leonard Lyubich <[email protected]>
Signed-off-by: Leonard Lyubich <[email protected]>
Signed-off-by: Leonard Lyubich <[email protected]>
Signed-off-by: Leonard Lyubich <[email protected]>
roman-khimov
approved these changes
Oct 14, 2024
| // IsZero checks whether all fields of the table are zero/empty. The property | ||
| // can be used as a marker of unset eACL. | ||
| func (t Table) IsZero() bool { | ||
| return t.cid.IsZero() && len(t.records) == 0 && t.version == version.Version{} |
carpawell
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.