Move policy from node repo #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterSplinter01
changed the title
…ncies Signed-off-by: Angira Kekteeva <[email protected]>
masterSplinter01
force-pushed
the
feature/116-move-policy-from-node-repo
branch
from
5ed02af
to
2c5d73d
Compare
masterSplinter01
force-pushed
the
feature/116-move-policy-from-node-repo
branch
from
2c5d73d
to
d5c6aed
Compare
…edit .gitignore Add coverage and ide files to gitignore Signed-off-by: Angira Kekteeva <[email protected]>
masterSplinter01
force-pushed
the
feature/116-move-policy-from-node-repo
branch
2 times, most recently
from
80c0a7c
to
bb6dc71
Compare
…romNetmap functions fromNetmap func is used in the function that presents data of placement policy as json Signed-off-by: Angira Kekteeva <[email protected]>
…, fix typos Signed-off-by: Angira Kekteeva <[email protected]>
|
Fixed linter warnings (except of grammar.go). |
There was a problem hiding this comment.
- Where the original version comes from? I see some difference between current state of pkg/policy of neofs-node and the thing we have here (and it'd be nice to specify neofs-node commit here anyway).
- You can do
diff --git a/pkg/policy/grammar.go b/pkg/policy/grammar.go
index 0a7ce7f..cc4220a 100644
--- a/pkg/policy/grammar.go
+++ b/pkg/policy/grammar.go
@@ -1,3 +1,4 @@
+//nolint:govet,golint // fails on struct tags here, but participle needs this syntax
package policy
import (
To fix linter warnings in grammar.go.
cthulhu-rider
added a commit
that referenced
this pull request
Jul 31, 2024
Previously, any token w/o lifetime field was always considered as invalid (expired in particular). In the protocol, the lifetime field's absence is equivalent to all zero claims. Thus, `InvalidAt` and `ExpiredAt` methods behaved correctly for all cases except default one. At the same time, if user explicitly set all lifetime claims to zero - token was not invalid at the epoch #0. From now skipping a lifetime field in a token message is equivalent to a field with all zeros. This change will only affect epoch #0 and will be invisible in practice since the NeoFS network starts from epoch #1. In addition, the internal structure of the type has been simplified. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
added a commit
that referenced
this pull request
Aug 26, 2024
Previously, any token w/o lifetime field was always considered as invalid (expired in particular). In the protocol, the lifetime field's absence is equivalent to all zero claims. Thus, `InvalidAt` and `ExpiredAt` methods behaved correctly for all cases except default one. At the same time, if user explicitly set all lifetime claims to zero - token was not invalid at the epoch #0. From now skipping a lifetime field in a token message is equivalent to a field with all zeros. This change will only affect epoch #0 and will be invisible in practice since the NeoFS network starts from epoch #1. In addition, the internal structure of the type has been simplified. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
added a commit
that referenced
this pull request
Sep 18, 2024
Previously, any token w/o lifetime field was always considered as invalid (expired in particular). In the protocol, the lifetime field's absence is equivalent to all zero claims. Thus, `InvalidAt` and `ExpiredAt` methods behaved correctly for all cases except default one. At the same time, if user explicitly set all lifetime claims to zero - token was not invalid at the epoch #0. From now skipping a lifetime field in a token message is equivalent to a field with all zeros. This change will only affect epoch #0 and will be invisible in practice since the NeoFS network starts from epoch #1. In addition, the internal structure of the type has been simplified. Signed-off-by: Leonard Lyubich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved package policy from repository neofs-node.
Created Makefile and go.mod.