Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort parts by number and server creation time #929

Conversation

smallhive
Copy link
Contributor

@smallhive smallhive commented Feb 12, 2024

Closes #901.

During my first review, I didn't make two fields sort, only one - this was an error point.

Runed

S3TEST_CONF=s3tests.conf tox -- s3tests_boto3/functional/test_s3.py::test_multipart_resend --disable-warnings

Before changes

80 failed, 70 passed in 408.67s (0:06:48)

After changes

150 passed in 402.04s (0:06:42)

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (205f942) 33.68% compared to head (72d5830) 33.60%.
Report is 5 commits behind head on master.

Files Patch % Lines
internal/neofs/tree.go 0.00% 12 Missing ⚠️
api/layer/multipart_upload.go 0.00% 11 Missing ⚠️
api/layer/tagging.go 0.00% 7 Missing ⚠️
api/handler/unimplemented.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #929      +/-   ##
==========================================
- Coverage   33.68%   33.60%   -0.08%     
==========================================
  Files          64       64              
  Lines       10834    10859      +25     
==========================================
  Hits         3649     3649              
- Misses       6777     6802      +25     
  Partials      408      408              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smallhive smallhive force-pushed the 901-completemultipartupload-sometimes-fail-after-resending-same-part branch 4 times, most recently from d10b782 to 8dc3597 Compare February 12, 2024 09:47
@smallhive smallhive force-pushed the 901-completemultipartupload-sometimes-fail-after-resending-same-part branch from 8dc3597 to 72d5830 Compare February 13, 2024 04:09
@roman-khimov roman-khimov merged commit b297320 into master Feb 13, 2024
12 of 16 checks passed
@roman-khimov roman-khimov deleted the 901-completemultipartupload-sometimes-fail-after-resending-same-part branch February 13, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompleteMultipartUpload sometimes fail after resending same part
2 participants