Add slicer as an option #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
808-add-an-option-to-slice-objects
branch
from
f3367c7
to
ca2d98a
Compare
Codecov Report
@@ Coverage Diff @@
## master #831 +/- ##
==========================================
- Coverage 34.05% 33.90% -0.16%
==========================================
Files 61 62 +1
Lines 10472 10519 +47
==========================================
Hits 3566 3566
- Misses 6505 6552 +47
Partials 401 401
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmd/s3-gw/app_settings.go
Outdated
| // List of allowed AccessKeyID prefixes. | ||
| cfgAllowedAccessKeyIDPrefixes = "allowed_access_key_id_prefixes" | ||
|
|
||
| // envPrefix is an environment variables prefix used for configuration. | ||
| envPrefix = "S3_GW" | ||
|
|
||
| // Shows if slicer is enabled. If enabled slicer will be used for object put. | ||
| cfgSlicerEnabled = "slicer.enabled" |
There was a problem hiding this comment.
internal_slicer? I'm not sure what would be the best name for it.
There was a problem hiding this comment.
I'm not sure, that I like internal in this case. Renamed
There was a problem hiding this comment.
Internal for the S3 gateway. Otherwise it happens in the NeoFS node, thus can be considered external to the S3 gateway. Maybe there are better options.
closes #808 Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
808-add-an-option-to-slice-objects
branch
from
ca2d98a
to
39412e8
Compare
roman-khimov
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #808