Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NoOpResolver #830

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Remove NoOpResolver #830

merged 2 commits into from
Sep 26, 2023

Conversation

smallhive
Copy link
Contributor

closes #813

@smallhive
resolver: Remove NoOpResolver
bb3dc1d 
closes #813

Signed-off-by: Evgenii Baidakov <[email protected]>
@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Merging #830 (6211075) into master (d4c7e11) will not change coverage.
Report is 4 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #830   +/-   ##
=======================================
  Coverage   34.05%   34.05%           
=======================================
  Files          61       61           
  Lines       10472    10472           
=======================================
  Hits         3566     3566           
  Misses       6505     6505           
  Partials      401      401

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@smallhive smallhive marked this pull request as ready for review September 22, 2023 08:16
roman-khimov
roman-khimov reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have resolve_order mentioned in docs/configuration.md, would be nice to fix it as well.

@smallhive
Copy link
Contributor Author

We still have resolve_order mentioned in docs/configuration.md, would be nice to fix it as well.

Whoops, updated

roman-khimov
roman-khimov reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many whitespace changes.

docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
docs/configuration.md Show resolved Hide resolved
docs/configuration.md Outdated Show resolved Hide resolved
@smallhive
Copy link
Contributor Author

Autoformat is a good thing, but leads to whitespace changes. Reverted them

@roman-khimov roman-khimov merged commit 102b6ec into master Sep 26, 2023
13 of 14 checks passed
@roman-khimov roman-khimov deleted the 813-drop-noop-resolver branch September 26, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop noop resolver
2 participants
@smallhive @roman-khimov