object/put: log meta errors instead of erroring out #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
We don't have this finished yet, so it'd be safer for 0.44.0 to just log any errors, but continue working as it worked before. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
log-meta-errors
branch
from
6501908 to
f3b12fd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3029 +/- ##
=======================================
Coverage 22.62% 22.63%
=======================================
Files 791 791
Lines 58526 58531 +5
=======================================
+ Hits 13244 13247 +3
- Misses 44384 44387 +3
+ Partials 898 897 -1 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have this finished yet, so it'd be safer for 0.44.0 to just log any errors, but continue working as it worked before.