Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: add metrics for shard's capacity #3022

Merged
merged 1 commit into from
Nov 25, 2024
Merged

node: add metrics for shard's capacity #3022

merged 1 commit into from
Nov 25, 2024
+60 −11

Conversation

End-rey
Copy link
Contributor

@End-rey End-rey commented Nov 21, 2024

Closes #1794.

@End-rey End-rey self-assigned this Nov 21, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 21.42857% with 33 lines in your changes missing coverage. Please review.

Project coverage is 22.85%. Comparing base (339b4cb) to head (0d7673b).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
cmd/neofs-node/metrics.go 0.00% 15 Missing ⚠️
cmd/neofs-node/config.go 0.00% 13 Missing ⚠️
cmd/neofs-node/main.go 0.00% 3 Missing ⚠️
pkg/metrics/engine.go 81.81% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3022   +/-   ##
=======================================
  Coverage   22.85%   22.85%           
=======================================
  Files         791      791           
  Lines       58734    58767   +33     
=======================================
+ Hits        13425    13433    +8     
- Misses      44412    44437   +25     
  Partials      897      897

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@End-rey End-rey force-pushed the 1794-add-metrics-for-capacity-in-node branch 2 times, most recently from 38ea461 to 14b21ae Compare November 22, 2024 09:11
roman-khimov
roman-khimov reviewed Nov 22, 2024
View reviewed changes
pkg/metrics/engine.go Outdated Show resolved Hide resolved
@End-rey End-rey force-pushed the 1794-add-metrics-for-capacity-in-node branch from 14b21ae to 11c9289 Compare November 25, 2024 14:43
@End-rey
node: add neofs_node_engine_capacity metric
0d7673b 
Expose metric for shard's capacity.

Closes #1794.

Signed-off-by: Andrey Butusov <[email protected]>
@End-rey End-rey force-pushed the 1794-add-metrics-for-capacity-in-node branch from 11c9289 to 0d7673b Compare November 25, 2024 15:21
@carpawell carpawell merged commit f90a3d3 into master Nov 25, 2024
21 of 22 checks passed
@carpawell carpawell deleted the 1794-add-metrics-for-capacity-in-node branch November 25, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carpawell carpawell carpawell approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

Assignees

@End-rey End-rey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metrics for shard's capacity
3 participants
@End-rey @roman-khimov @carpawell